WIP: Support for file upload #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonoff
reviewed
Feb 18, 2020
| @@ -0,0 +1,37 @@ | |||
| require 'open-uri' | |||
There was a problem hiding this comment.
Is this required? There is possibility to use a url as file. Not sure if this secure enough.
There was a problem hiding this comment.
maybe it would be better if #upload expects a file/IO object, instead of URL/filename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the File client follows the same implementation as all other endpoints. If you want to upload a file though, the API expects a multipart request containing the file contents + parameters.
This PR tries to solve this by introducing a new convern
Upload.Unfortunately this is a very recent feature of Faraday (>= v1.0), so I had to introduce that version constraint.
Furthermore, the Faraday guys haven't released a new, compatible version of
faraday_middlewareyet (see lostisland/faraday_middleware#200), so this gem is temporarily bound to the corresponding Github commit (lostisland/faraday_middleware@e169ab2).Because of this I open this PR as draft and to be discussed.
Cheers