Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP440 qualified package name #404

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

NKcqx
Copy link
Collaborator

@NKcqx NKcqx commented Aug 5, 2023

Releasing ant-ray in pypi encounter naming issue because PEP440 declares that local version names like "occlum" SHOULD NOT be used in public index server. Only [a | b | rc | post] N can be used.
As this "occlum" version is a enhancement of original "1.13.0", this should be a "post" version.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@NKcqx NKcqx requested a review from jovany-wang August 5, 2023 01:52
@NKcqx NKcqx merged commit 3ee23aa into releases/1.13.0-occlum Aug 9, 2023
1 check passed
@jovany-wang jovany-wang deleted the release_version_name branch August 9, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants