fixed #57 #58

akaunting · Mar 20, 2023 · 16f7db9 · 16f7db9
1 parent 6a44c0b
commit 16f7db9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Config/firewall.php b/src/Config/firewall.php
@@ -4,7 +4,7 @@
 
     'enabled' => env('FIREWALL_ENABLED', true),
 
-    'whitelist' => [env('FIREWALL_WHITELIST', '')],
+    'whitelist' => explode(',', env('FIREWALL_WHITELIST', '')),
 
     'models' => [
         'user' => '\App\Models\User',

diff --git a/tests/Feature/WhitelistTest.php b/tests/Feature/WhitelistTest.php
@@ -3,7 +3,6 @@
 namespace Akaunting\Firewall\Tests\Feature;
 
 use Akaunting\Firewall\Middleware\Whitelist;
-use Akaunting\Firewall\Models\Ip as Model;
 use Akaunting\Firewall\Tests\TestCase;
 
 class WhitelistTest extends TestCase
@@ -15,6 +14,13 @@ public function testShouldAllow()
         $this->assertEquals('next', (new Whitelist())->handle($this->app->request, $this->getNextClosure()));
     }
 
+    public function testShouldAllowMultiple()
+    {
+        config(['firewall.whitelist' => ['127.0.0.0/24', '127.0.0.1']]);
+
+        $this->assertEquals('next', (new Whitelist())->handle($this->app->request, $this->getNextClosure()));
+    }
+
     public function testShouldBlock()
     {
         $this->assertEquals('403', (new Whitelist())->handle($this->app->request, $this->getNextClosure())->getStatusCode());