Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Defer creation of SimpleCookie objects in the web server until needed #9895

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 15, 2024

related issue #2779

We create these objects even if there are no cookies. There are some small performance improvements and some memory savings on each request. Total time spent in the request response was ~24% so it likely works out to a 1% speed up.

Screenshot 2024-11-14 at 8 00 43 PM Screenshot 2024-11-14 at 8 00 39 PM

related issue #2779

We create these objects even if there are no cookies
@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #9895 will not alter performance

Comparing web_cookies_lazy (6b63eba) with master (5ab2d47)

Summary

✅ 25 untouched benchmarks

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.71%. Comparing base (5ab2d47) to head (6b63eba).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/helpers.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9895   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         119      119           
  Lines       36371    36375    +4     
  Branches     4320     4323    +3     
=======================================
+ Hits        35903    35907    +4     
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.60% <87.50%> (+<0.01%) ⬆️
OS-Linux 98.29% <87.50%> (+<0.01%) ⬆️
OS-Windows 96.09% <ø> (ø)
OS-macOS 97.37% <87.50%> (+<0.01%) ⬆️
Py-3.10.11 97.22% <87.50%> (+<0.01%) ⬆️
Py-3.10.15 97.77% <87.50%> (-0.06%) ⬇️
Py-3.11.10 97.82% <87.50%> (+<0.01%) ⬆️
Py-3.11.9 97.26% <87.50%> (-0.01%) ⬇️
Py-3.12.7 98.36% <87.50%> (+<0.01%) ⬆️
Py-3.13.0 98.29% <87.50%> (-0.05%) ⬇️
Py-3.9.13 97.14% <87.50%> (+<0.01%) ⬆️
Py-3.9.20 97.69% <87.50%> (-0.05%) ⬇️
Py-pypy7.3.16 97.30% <87.50%> (-0.01%) ⬇️
VM-macos 97.37% <87.50%> (+<0.01%) ⬆️
VM-ubuntu 98.29% <87.50%> (+<0.01%) ⬆️
VM-windows 96.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant