Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect username on macOS self-hosted runners #708

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fkorotkov
Copy link

Description:

Right now it's hardcoded to "runner". I'm not sure why it's hardcoded on macOS in the first place. I tried to dig some history in #466 made by @techman83 but have not spent enough time to get to the root cause.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Right now it's hardcoded to "runner"
@fkorotkov fkorotkov requested a review from a team as a code owner July 25, 2023 21:35
@techman83
Copy link
Contributor

IIRC I didn't change the mac path, because this related to how actions/setup-python compiles (at least compiled when I submitted my PR) the python libraries. Covered by the commit comment:

Shared libraries for the Mac python builds are not configured with the
relocatable flag, thus must always be configured with the hosted path.

It'll be worth referencing where this was fixed upstream, but there was definitely a reason 🙂

@dmitry-shibanov
Copy link
Contributor

Hello @fkorotkov. Could you please run the npm run format && npm run build command ?

@fkorotkov
Copy link
Author

@dmitry-shibanov my bad! I only ran npm run build. Formatted code in 2750121 and npm run builded just in case but nothing changed.

@jonluca
Copy link

jonluca commented Oct 26, 2023

Hi Is there an update on this? Would be great to get this working :)

@kvasilye
Copy link

Any update on merging this?

We use self hosted MacOS runners and are unable to upgrade to python-setup v5

@oscarbetancurj
Copy link

Hi. When are you going to merge this? I have same issue right now. Thanks!!

@priya-kinthali
Copy link
Contributor

Hello @fkorotkov 👋,
Thank you for your contribution!
We have reviewed this PR and encountered an error when testing it on a self-hosted runner with Python versions below 3.11. It appears that the changes are not compatible with these earlier versions.
The error is as follows:
Reason: tried: '/Users/runner/hostedtoolcache/Python/3.10.11/x64/lib/libpython3.10.dylib' (no such file)
You can view the detailed logs here.
Could you please take a look?
Thanks in advance!

@kvasilye
Copy link

Hello, can this be merged please?

This bug is blocking us from upgrading out of v3.

@fkorotkov
Copy link
Author

@priya-kinthali sorry I missed you message. The link does not work now and I'm not sure how this change could work with one version of Python and not another. On a self-hosted runner with runner username it should work as expected.

For anyone looking for a workaroud, for our managed GitHub Actions Runners service we ended up linking /Users/runner in our virtual machines:

https://github.com/cirruslabs/macos-image-templates/blob/159d4c1c3662c02c7148f2fc9fae23f4e0230c56/templates/base.pkr.hcl#L74-L82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants