Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Build and Deploy jobs on forks instead of failing them #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip Build and Deploy jobs on forks instead of failing them #153

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0808358
Attempt to build and deploy Pages only on the main repo to avoid erro…
mattmaniak Jan 8, 2025
7e67be3
Try to skip only Deploy job
mattmaniak Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/mdbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ concurrency:

jobs:
build:
if: github.repository == 'Whisky-App/whisky-book'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be skipping the deployment step and not the build step. It's still valuable to make sure that build is working as intended on forks.

Copy link
Member Author

@mattmaniak mattmaniak Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it but it fails on my fork always at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip the setup pages step, but not the entire job

runs-on: ubuntu-latest
env:
MDBOOK_VERSION: 0.4.37
Expand Down
Loading