Add test files for wabtjs #2371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remind me what downstream project this code is coming from? Can you mention that in the descirption and link to the downstream code? If we go ahead with this is its probably work working with downstream to migrate these tests such that they can then be removed from downstream (no point testing the same thing in multiple places). |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some bugs are caused by not enough test in wabt.post.js, such as
#2367
#2365
Some test cases of wabt.post.js need to be added to grantee code quality.
One proposal is to migrate the test cases of wabt.js. Because wabt.js is just a npm wrapper of wabt, a lot of user also use wabt from wabt.js by npm install.
But if maintainer have other ideas to test wabt.post.js, I can also try them.