Use OpenJDK version of JPackage #969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinShalit
force-pushed
the
actions
branch
from
d5d4676
to
d064a29
Compare
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
============================================
+ Coverage 52.35% 52.36% +0.01%
Complexity 1 1
============================================
Files 333 333
Lines 9080 9080
Branches 575 575
============================================
+ Hits 4754 4755 +1
Misses 4121 4121
+ Partials 205 204 -1 |
AustinShalit
force-pushed
the
actions
branch
from
acf7451
to
8f50409
Compare
|
I think I am trying to revert #965 with this PR. |
AustinShalit
force-pushed
the
actions
branch
3 times, most recently
from
282362d
to
d064a29
Compare
|
This fixes the MacOS launch issue but not the memory issue. |
|
@AustinShalit is this good to merge? |
|
Need to test this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing to see if this fixes the MacOS launch issue.