-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osx tray #124
base: main
Are you sure you want to change the base?
Osx tray #124
Conversation
* moving the non-windows stuff out * mac app skeleton * base menu structure and popup window * mac messagebox impl * mac tray app skeleton
@HEskandari replacement PR |
i got it building on CI, but 3 failing tests on mac. https://ci.appveyor.com/project/SimonCropp/diffengine/builds/35930418/job/q3vhl95r7uhbirhe/tests i will try to debug them tomorrow |
@HEskandari actually we seem to have some build errors
any ideas on how to get xamarin working on appveyor |
@SimonCropp hmmm why is it using .NET 5 SDK? |
According to this, that is the latest version of the .NET installed on their macos agents. I think we may need to lock it down to 3.1 (e.g. .NET Core SDK 3.1.300) with a global.json file? |
any plans to release the osx one, or will the tool remain windows only? |
@kaylumah i would really like to. unfortunately at the moment i dont have a mac to develop on. so as u can imagine that makes building an maintaining this difficult. i plan to make my next dev machine a max, but that wont happen for a few months in the short term, if u r using rider you can use https://plugins.jetbrains.com/plugin/17240-verify-support |
Oh yeah, I can imagine. |
The cross-platform library I was using for the tray app had some issues that had to be fixed first. I'll give this another go in a couple of weeks and see if it can be done now. |
For reference, here's the repo I'm working off of. Got some success with the latest of the UI toolkit on the mac. Needs more testing, add packaging for mac and windows and add some configurations to allow supporting .NET and Golang solutions. |
@HEskandari thats awesome |
@SimonCropp @kaylumah I have an alpha release out available here. Needs some minor work but the bulk of it is working on my mac (Ventura). Let me know if you have an issue. Note that I don't have a cert to sign the app so you may need allow it to run. |
@HEskandari could it be deployed as a dotnet tool ? |
The output of the build are two artifacts:
If you want to install it as an Application in MacOs, you want the .app format, but theoretically, the binary is a mac-native binary so can be invoked by anything. You probably know that you can extract the binary by opening the '.app' file as a folder (via terminal or right-click -> "Show Package Content" and then copying the binary from the MacOS folder). |
@HEskandari do u want your diff tray to be part of the main verify project? ie part of the DNF |
@SimonCropp ultimately yes, I think. There are a few things I haven't coded yet (like having more than 20 diff files). I need to figure out packaging and do a bit more testing. You may want to keep the DiffEngine tray app for some time for this to become more mature. |
No description provided.