Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q ctable test #545

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Q ctable test #545

merged 7 commits into from
Nov 14, 2024

Conversation

hillarymarler
Copy link
Collaborator

Validation table test. Instructions for how to identify causes of test failure are included in Maintenance.R. Currently, the Maintenance.R file instructions/code are commented out. They include creating and saving a csv to share with the wqx team. I created a testresults folder in "testthat" to save the results. But I could also set it up to save in the downloads folder if that is preferable.

Validation table test and instructions for how to identify rows for update by WQX team, added testresults folder for output
@cristinamullin
Copy link
Collaborator

I think I'd prefer this to be saved to the downloads folder so that it does not accidentally get included in the package (cluttering/taking up space). Alternatively the folder itself and file could be added to .gitignore so that doesn't happen. Either works

@hillarymarler
Copy link
Collaborator Author

I'll get it switched to the downloads folder - that makes the most sense overall, the more I think it about it.

@cristinamullin cristinamullin merged commit 2d4bcf6 into develop Nov 14, 2024
7 checks passed
@cristinamullin cristinamullin deleted the QCtable_test branch November 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants