refactor(svelte-query): rename FunctionedParams<T> to Accessor<T> for improved semantics and consistency, use in function return types #8534
+29
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames
FunctionedParams<T>
toAccessor<T>
to improve code clarity and align with established patterns in the ecosystem. The change brings several key benefits:Accessor<T>
aligns with established patterns, particularly SolidJS'sAccessor
utility type.For example, you can already see this same pattern is used in
solid-query
's createQuery.ts, createQueries.ts, isRestoring.tsSemantic Clarity: The term "Accessor" better describes the type's purpose - a function that provides access to a value. The previous name
FunctionedParams
was ambiguous and could be misinterpreted as parameters that have been "functioned" or transformed.Removal of Redundancy: The word "Params" in
FunctionedParams<T>
was redundant since this type is already used in parameter positions. For example:useIsFetching
,useIsMutating
,useIsRestoring
, andcontext
functions. This creates a unified type pattern for functions that provide access to reactive values.