Upgraded Magick.NET. #1383
Merged
Upgraded Magick.NET. #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlemstra Doesn't this mean that according to Magick.NET our encoder is setting the length incorrectly? We have new exceptions thrown in our |
|
That could be a possibility then. Will investigate that this weekend. Thought the input was coming from a random test file. |
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 690 690
Lines 31074 31074
Branches 3512 3512
=======================================
Hits 25747 25747
Misses 4605 4605
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tests/ImageSharp.Tests/TestUtilities/ReferenceCodecs/MagickReferenceDecoder.cs
Show resolved
Hide resolved
…erenceDecoder.cs Co-authored-by: James Jackson-South <[email protected]>
JimBobSquarePants
added a commit
that referenced
this pull request
Mar 13, 2021
Upgraded Magick.NET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This updates Magick.NET and sets an option for the BMP coder that fixes #1380. This option was added because the BMP coder in ImageMagick is now stricter and you need to set it to be able to read all files.