-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added the host list view and filters #6210
base: infra-monitoring
Are you sure you want to change the base?
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to f8eeec6 in 40 seconds
More details
- Looked at
1063
lines of code in29
files - Skipped
0
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/HostsList.tsx:10
- Draft comment:
Missing semicolon at the end of the import statement forHostsListControls
. - Reason this comment was not posted:
Confidence changes required:10%
The import statement forHostsListControls
is missing a semicolon at the end. This is a minor style issue but should be corrected for consistency.
2. frontend/src/pages/InfraMonitoringHosts/HostsList.tsx:30
- Draft comment:
Remove theconsole.log(options);
statement to maintain clean code. - Reason this comment was not posted:
Confidence changes required:10%
The console.log statement is likely used for debugging purposes and should be removed before merging the code to maintain clean code practices.
3. frontend/src/pages/InfraMonitoringHosts/HostsListControls.tsx:27
- Draft comment:
Remove theconsole.log('currentQuery', updatedCurrentQuery);
statement to maintain clean code. - Reason this comment was not posted:
Confidence changes required:10%
Theconsole.log
statement is likely used for debugging and should be removed before merging to maintain clean code practices.
4. frontend/src/pages/InfraMonitoringHosts/utils.tsx:36
- Draft comment:
ThedataIndex
values ingetHostsListColumns
should match the keys in the data source. UsehostName
,cpu
,memory
, anddisk
instead ofhostname
,cpu_usage
,memory_usage
, anddisk_usage
. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment assumes that thedataIndex
values do not match the data source keys, but there is no evidence in the provided code to support this claim. Without seeing the data source or additional context, it's speculative to assume the suggested changes are necessary. The comment does not provide strong evidence that a code change is required.
The data source is not visible in the provided code, so it's possible that the currentdataIndex
values are correct. The comment might be based on an assumption rather than evidence.
Without evidence from the data source, it's safer to assume the currentdataIndex
values are correct. The comment lacks strong evidence to support its claim.
Delete the comment as it lacks strong evidence and is speculative about the need for changes todataIndex
values.
5. frontend/src/pages/InfraMonitoringHosts/HostsList.tsx:60
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Comment was on unchanged code.
6. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoring.styles.scss:15
- Draft comment:
Avoid using hardcoded color values. Use design tokens or predefined color constants instead. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The code uses CSS variables (e.g., var(--bg-slate-400)), which are typically used for design tokens or predefined constants. This suggests that the comment may not be applicable, as the code is already following best practices by not hardcoding color values directly.
I might be misunderstanding the nature of the variables used. If these variables are not part of a design system, the comment could be valid. However, CSS variables are generally used for this purpose.
Given the use of CSS variables, it's reasonable to assume they are part of a design system unless there's evidence to the contrary. The comment seems unnecessary.
The comment should be deleted because the code already uses CSS variables, which are likely design tokens or predefined constants.
Workflow ID: wflow_m6k1zhwRpx3LczB7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ae014d1 in 34 seconds
More details
- Looked at
351
lines of code in11
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. frontend/src/api/infraMonitoring/getHostLists.ts:58
- Draft comment:
Ensure that the backend API endpoint '/hosts/list' is correctly configured to handle this request. The change from '/hosts' to '/hosts/list' might break the API call if not updated in the backend. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/constants/localStorage.ts:24
- Draft comment:
The removal ofINFRAMONITORING_HOSTS_LIST_OPTIONS
might affect functionality relying on this key. Ensure it's not used elsewhere in the codebase. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/src/container/HostMetricsLoading/HostMetricsLoading.tsx:14
- Draft comment:
Consider using a constant or configuration for the loading GIF path to avoid issues if the file path changes. - Reason this comment was not posted:
Confidence changes required:50%
TheHostMetricsLoading
component is well-structured, but the hardcoded path for the loading GIF might cause issues if the file path changes. Consider using a constant or configuration for the path.
4. frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx:101
- Draft comment:
The addition ofisInfraMonitoring
parameter touseAutoComplete
is consistent. Ensure this parameter is used correctly within the hook. - Reason this comment was not posted:
Confidence changes required:30%
TheuseAutoComplete
hook now accepts anisInfraMonitoring
parameter, which is correctly passed in theQueryBuilderSearch
component. This change is consistent across the files whereuseAutoComplete
is used.
5. frontend/src/pages/InfraMonitoringHosts/HostsListControls.tsx:28
- Draft comment:
Removeconsole.log
statements before deploying to production to avoid unnecessary logging. - Reason this comment was not posted:
Confidence changes required:50%
TheHostsList
component usesuseMemo
for memoizing the query and columns, which is a good practice for performance optimization. However, theconsole.log
statement should be removed before production deployment.
6. frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx:94
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable in other parts of the code where inline styles are used. - Reason this comment was not posted:
Comment was on unchanged code.
7. frontend/src/pages/InfrastructureMonitoring/InfrastructureMonitoring.styles.scss:8
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values to maintain consistency in design and theming. This is also applicable in other parts of the code where color values are hardcoded. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_VnNQTjsCZN7S0B0j
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 08512b9 in 26 seconds
More details
- Looked at
249
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/HostsList.tsx:56
- Draft comment:
Consider using a more specific type forpagination
instead ofany
to improve type safety. - Reason this comment was not posted:
Confidence changes required:50%
The use ofany
for thepagination
parameter inhandleTableChange
is not ideal. It's better to use a more specific type to improve type safety and code readability.
2. frontend/src/pages/InfraMonitoringHosts/utils.tsx:76
- Draft comment:
EnsurehostName
is always a valid string. Ifhost.hostName
can be empty, consider handling this case explicitly. - Reason this comment was not posted:
Confidence changes required:50%
ThehostName
field in theHostRowData
interface is marked as a string, but in theformatDataForTable
function, it is being assigned an empty string ifhost.hostName
is falsy. This could lead to inconsistencies ifhostName
is expected to always have a value.
3. frontend/src/pages/InfraMonitoringHosts/utils.tsx:24
- Draft comment:
Ensure that the time conversion to milliseconds is consistent with the rest of the application. If the original times are already in milliseconds, this multiplication is unnecessary. - Reason this comment was not posted:
Confidence changes required:33%
ThegetHostListsQuery
function multiplies the start and end times by 1e3, which converts them to milliseconds. This is correct if the original times are in seconds, but it's important to ensure this is consistent with the rest of the application.
Workflow ID: wflow_xrcUcGSRC66u5LLv
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 3d57dde in 29 seconds
More details
- Looked at
91
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/HostsListControls.tsx:39
- Draft comment:
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_kvrpqLgZC8OJlOia
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 689440b in 41 seconds
More details
- Looked at
177
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/utils.tsx:116
- Draft comment:
Avoid using inline styles. Consider using external stylesheets or styled components for better maintainability. This is also applicable to line 104. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_vA3uynBkzrtGWieA
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 403fe9d in 47 seconds
More details
- Looked at
186
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/utils.tsx:63
- Draft comment:
ThedataIndex
for 'IOWait' should beioWait
to match theHostRowData
interface. This will ensure consistency and prevent potential bugs. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment points out a potential inconsistency between thedataIndex
and theHostRowData
interface. However, theformatDataForTable
function mapshost.wait
toioWait
, which means thedataIndex
should indeed bewait
to match the data source. The comment is incorrect because the change aligns thedataIndex
with the data source, not the interface.
I might be missing the importance of aligning thedataIndex
with theHostRowData
interface instead of the data source. However, the functionformatDataForTable
clearly mapshost.wait
toioWait
, indicating thedataIndex
should match the data source.
The mapping informatDataForTable
is a strong indication that thedataIndex
should bewait
, as it reflects the data source structure. The comment is incorrect in suggesting a change toioWait
.
The comment is incorrect because thedataIndex
should match the data source, which iswait
, not theHostRowData
interface. The comment should be deleted.
2. frontend/src/pages/InfraMonitoringHosts/utils.tsx:89
- Draft comment:
Avoid using inline styles in React components. Consider using external stylesheets, CSS classes, or styled components instead. This is also applicable at line 104. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is relevant because it addresses a change made in the diff, specifically the use of inline styles in the formatDataForTable function. The suggestion to use external stylesheets or styled components is a common best practice in React development to improve maintainability and consistency. Therefore, the comment is actionable and clear, aligning with the rules for review comments.
The comment might be considered too general, as it doesn't provide specific guidance on how to refactor the inline styles. However, the suggestion is a well-known best practice, and the comment is relevant to the changes made in the diff.
While the comment could be more specific, it still provides a valid and actionable suggestion that aligns with best practices. The relevance to the changes made in the diff justifies keeping the comment.
Keep the comment as it provides a relevant and actionable suggestion regarding the use of inline styles in the updated code.
3. frontend/src/pages/InfraMonitoringHosts/utils.tsx:104
- Draft comment:
Avoid using inline styles in React components. Consider using external stylesheets, CSS classes, or styled components instead. This is also applicable at line 89. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_4ui1KK6MDreGH8h1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6648e84 in 36 seconds
More details
- Looked at
92
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/HostsList.tsx:101
- Draft comment:
The dependency array foruseCallback
should includesetFilters
to ensure the callback updates whensetFilters
changes. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is directly related to the change made in the diff, which is the removal ofsetFilters
from the dependency array. The comment suggests that this change might be incorrect because it could lead to issues ifsetFilters
changes. This is a valid concern becauseuseCallback
should include dependencies that are used within the callback to ensure it updates correctly.
The comment might be unnecessary ifsetFilters
is guaranteed not to change, or if the function is intended to be static. However, without more context, it's safer to assume the comment is valid.
Given thatsetFilters
is a state setter function fromuseState
, it is unlikely to change, but the comment is still valid as a precautionary measure.
Keep the comment as it addresses a potential issue with the dependency array ofuseCallback
.
2. frontend/src/pages/InfraMonitoringHosts/HostsListControls.tsx:44
- Draft comment:
The dependency array foruseCallback
should includehandleChangeQueryData
andhandleFiltersChange
to ensure the callback updates when these dependencies change. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. frontend/src/pages/InfraMonitoringHosts/utils.tsx:89
- Draft comment:
Avoid using inline styles. Use CSS classes or styled components instead. This applies to other similar instances in this file. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is relevant because it addresses a change made in the diff, where inline styles were replaced with CSS classes. This aligns with best practices for styling in React components. The comment is not redundant or speculative, and it provides a clear suggestion that has been implemented in the code changes.
The comment might be considered unnecessary since the change has already been made, and the code now follows the suggested practice. However, it reinforces the importance of the change and aligns with best practices.
While the change has been made, the comment serves as a useful reminder of best practices and validates the change. It is relevant to the diff and provides context for why the change was necessary.
The comment is relevant and should be kept as it addresses a change made in the diff and reinforces best practices for styling in React components.
4. frontend/src/pages/InfraMonitoringHosts/utils.tsx:104
- Draft comment:
Avoid using inline styles. Use CSS classes or styled components instead. This applies to other similar instances in this file. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_XJ4whbNq2PhlLk7X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
<Space> | ||
<img src="/Icons/broom.svg" alt="broom" width={16} height={16} /> | ||
<Text className="infra-container-card-text"> | ||
We're working to extend infrastructure monitoring to take care of a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to strings
</div> | ||
|
||
<Text className="infra-container-card-text"> | ||
Join the waitlist for early access or contact support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to strings
color: #fff; | ||
|
||
.ant-table-thead>tr>th { | ||
background: #121212; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
.ant-table-thead>tr>th { | ||
background: #121212; | ||
color: #fff; | ||
border-bottom: 1px solid #303030; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
} | ||
|
||
.ant-table-tbody>tr>td { | ||
background: #121212; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
} | ||
|
||
.ant-table-tbody>tr:hover>td { | ||
background: #1a1a1a; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
.ant-table-tbody>tr>td { | ||
background: #121212; | ||
color: #fff; | ||
border-bottom: 1px solid #303030; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
.duration-cell { | ||
display: inline-block; | ||
padding: 2px 8px; | ||
background: #d64937; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
padding: 2px 8px; | ||
background: #d64937; | ||
border-radius: 4px; | ||
color: #fff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use variables
border-radius: 4px; | ||
color: #fff; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lightMode styles are missing
}); | ||
|
||
useEffect(() => { | ||
if (data?.payload?.data?.newResult?.data?.result) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to variables
} | ||
}, [data, offset]); | ||
|
||
if (isLoading && traces.length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments on the different loading states
{isLoading && traces.length > 0 && ( | ||
<Skeleton | ||
style={{ | ||
height: '100%', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid inline styles
], | ||
queryFormulas: [], | ||
}, | ||
id: '572f1d91-6ac0-46c0-b726-c21488b34434', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a valid constant ?
@@ -0,0 +1,4 @@ | |||
export const formatNanoToMS = (nanoSeconds: number): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common util, move to common utils file
padding: 16px; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lightMode missing
isModalTimeSelection, | ||
}: Props): JSX.Element { | ||
const [modalTimeRange, setModalTimeRange] = useState(timeRange); | ||
const [, setSelectedInterval] = useState<Time>('5m'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we storing defaults similar to other places in the UI?
|
||
const query = updatedCurrentQuery?.builder?.queryData[0] || null; | ||
|
||
// const { handleChangeQueryData } = useQueryOperations({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code
<div className="host-metrics-logs-container"> | ||
<div className="host-metrics-logs-header"> | ||
<div className="filter-section"> | ||
{query && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the loading state till the query is populated ?
|
||
function HostMetricsLogs({ timeRange, filters }: Props): JSX.Element { | ||
const [logs, setLogs] = useState<ILog[]>([]); | ||
// const { initialDataSource, stagedQuery } = useQueryBuilder(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code from the file
debouncedFilters, | ||
); | ||
|
||
basePayload.query.builder.queryData[0].offset = prevOffset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add safety checks if required
return basePayload; | ||
}, [timeRange.startTime, timeRange.endTime, debouncedFilters, prevOffset]); | ||
|
||
const afterQueryPayload = useMemo(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulkeswani101 : Are we using this code ?
* feat: added the host detail view * feat: completed containers and processes details view * feat: added host metrics panels in metrics tabs * refactor: removed inline styles from host containers and processes tabs * feat: added logs and traces tab in host metrics detail view * chore: removed console statements * feat: added filters and time selection in traces tab * fix: resolved metrics,logs and traces tab issues * feat: added navigation for logs and traces to respective explorer pages * fix: added the code for logs tab and navigation to respective explorer page * fix: added fixes for date time selection custom issue * style: added styles for light mode
const endpoint = isInfraMonitoring | ||
? `/hosts/attribute_keys?dataSource=metrics&searchText=${searchText || ''}` | ||
: `/autocomplete/attribute_keys?${createQueryParams({ | ||
aggregateOperator, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is a complete endpoint change including the baseInstance
as well then it makes sense to create a new API and do not makes changes here.
@@ -916,6 +916,12 @@ export function QueryBuilderProvider({ | |||
], | |||
); | |||
|
|||
useEffect(() => { | |||
if (location.pathname === ROUTES.INFRASTRUCTURE_MONITORING_HOSTS) { | |||
setCurrentQuery(initialQueriesMap.metrics); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ? check how it is done for logs / traces explorer.
@@ -3,9 +3,10 @@ import { DataSource } from 'types/common/queryBuilder'; | |||
import { BaseAutocompleteData } from './queryAutocompleteResponse'; | |||
|
|||
export interface IGetAttributeKeysPayload { | |||
aggregateOperator: string; | |||
aggregateOperator?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make a new API and types to use this. adding optional checks on these makes the whole structure loosely typed
return [QueryBuilderKeys.GET_AGGREGATE_KEYS, ...options.queryKey]; | ||
return [ | ||
QueryBuilderKeys.GET_AGGREGATE_KEYS, | ||
...options.queryKey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have changes here as well and we have another useGetAggregateKeys
in infraMonitoring
hooks as well ?
interval, | ||
dateTimeRange, | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comments around what is being done here and why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the comments
Summary
Created a new page InfraMonitoring. Added host list tab and completed the initial view of showing filters and global time range.
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/1878
Screenshots
Screen.Recording.2024-10-22.at.1.05.55.PM.mov
Affected Areas and Manually Tested Areas
Important
Add infrastructure monitoring host list view with filters, including new API endpoints, hooks, components, and routes.
InfrastructureMonitoring
component inpageComponents.ts
and route inroutes.ts
.InfraMonitoringHosts
withHostsList
andHostsListControls
components.InfraMonitoring.styles.scss
andInfrastructureMonitoring.styles.scss
.getHostLists
andgetInfraAttributesValues
for fetching host data and attribute values.getAttributeKeys
to support infrastructure monitoring.useGetHostList
anduseGetAggregateKeys
for fetching host lists and aggregate keys.useFetchKeysAndValues
to handle infrastructure monitoring.INFRAMONITORING_HOSTS_LIST_OPTIONS
tolocalStorage.ts
.GET_HOST_LIST
toreactQueryKeys.ts
.INFRASTRUCTURE_MONITORING_HOSTS
toroutes.ts
andpermission/index.ts
.GroupByFilter
andQueryBuilderSearch
to support infrastructure monitoring.menuItems.tsx
.This description was created by for 6648e84. It will automatically update as commits are pushed.