Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user HOME dir for cache, config, models #253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

EricDeveaud
Copy link

related to #252

PR propose to have a $HOME/rfdiffusion that will hold all necessary files where write erpmission is required.
with this PR:

  • inference config files location are seaerchd from $HOME/rfdiffusion/config/inference/
  • IGSO3 are cahed to $HOME/rfdiffusion/schedules
  • weight models are exepected in $HOME/rfdiffusion/models

furthermore the PR allows weight models directory search to be overwritten by RFD_MODELS environment variable.
by default check in $HOME/rfdiffusion/models and search $RFD_MODELS instead if is defined
(allow mutualisation of models on a shared cluster)
same for inference config files, if RFD_HYDRA_CFG is defined.

regards

Eric

models weight directory may be specified by RFD_MODELS en var.
hydra config location may be overwitten by RFD_HYDRA_CFG env var
@roccomoretti
Copy link
Member

It might be better to use the user directory as a fall back. That is, instead of always writing to the user directory, only use the user directory if the installation directory isn't writable.

Additionally, I would probably recommend using a "hidden" directory (i.e. f"{USER_HOME}/.rfdiffusion") instead of the non-dotted one. (Creating a new top-level directory in a person's home directory that always shows up with a ls seems presumptuous. It also could be the case that they already have an rfdiffusion directory there, used for something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants