Skip writing client config if it is not writable #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the config file may be read-only. Since it is not imperative that it be written (everything continues to work, it just will not remember this device ID after a restart), just skip writing. Ideally static and dynamic configuration should be totally separated, however that is more complicated to implement and this is a quick fix.
amarshall
force-pushed
the
handle-readonly-client-config
branch
from
3fc2988 to
0bb19e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the config file may be read-only. Since it is not
imperative that it be written (everything continues to work, it just
will not remember this device ID after a restart), just skip writing.
Ideally static and dynamic configuration should be totally separated,
however that is more complicated to implement and this is a quick fix.
Partial workaround for #579.