Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference to hide posts with few comments #1176

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mosteo
Copy link

@mosteo mosteo commented Feb 12, 2024

This is pretty barebones but my Android coding skills are somewhat rusty.

@mosteo mosteo marked this pull request as ready for review February 12, 2024 13:08
@QuantumBadger
Copy link
Owner

Thank you for this! The code looks good, I'll test before merging.

@QuantumBadger
Copy link
Owner

Before merging this I think it would be good to improve the user experience a bit, in terms of disabling this feature. Currently by default, Hide posts with few comments: -1 is shown in the settings if this is disabled. We should avoid using -1 for this -- I think it would be better to split this into two preferences: one for enabling/disabling (a CheckboxPreference), and one for setting the numeric limit (which is greyed out if the other preference is disabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants