Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/upgrade Greenwood v0.31.0 #146

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 2, 2024

Related Issue

ProjectEvergreen/greenwood#1328

Summary of Changes

  1. Upgrade to Greenwood v0.31.0
  2. Update @import paths for open-props to favor non PostCSS dependent version
  3. Update project and guides to NodeJS 20.x LTS

TODO

  1. Nothing breaking, but seems like geist package is getting an import.meta.resolve error from NodeJS about its exports? 🤔
    ERROR (ERR_PACKAGE_PATH_NOT_EXPORTED): unable to resolve specifier => `geist`
    No "exports" main defined in /Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/geist/package.json imported from /Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/node_modules/@greenwood/cli/src/lib/walker-package-ranger.js
  2. Getting some unexpected css-tree parsing warnings from Open Props - ok, this just because CSS bundling is now working lol 😅 - alternative for shadows props without dependency on media props (e.g. custom media queries / PostCSS) argyleink/open-props#533
        Parse error: ")" is expected
        1 |@custom-media --motionOK      (prefers-reduced-motion: no-preference);
    ------------------------------------------------------------^
        2 |@custom-media --motionNotOK   (prefers-reduced-motion: reduce);
        3 |@custom-media --opacityOK     (prefers-reduced-transparency: no-preference);
    Parse error: ")" is expected
        1 |@custom-media --motionOK      (prefers-reduced-motion: no-preference);
        2 |@custom-media --motionNotOK   (prefers-reduced-motion: reduce);
  3. url("../../node_modules/geist/dist/fonts/geist-mono/GeistMono-Regular.woff2") is broken - bundling for CSS relative node_modules based url references breaks greenwood#1368
    Screenshot 2024-12-28 at 12 14 44 PM
  4. Bump branch checks for Node 22

@thescientist13 thescientist13 added the enhancement New feature or request label Dec 2, 2024
@thescientist13 thescientist13 self-assigned this Dec 2, 2024
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 754ff4b
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/678bef391bff1f0008966897
😎 Deploy Preview https://deploy-preview-146--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 added needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) and removed needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Dec 14, 2024
@thescientist13 thescientist13 force-pushed the enhancement/upgrade-greenwood-0.31.0 branch from 9c079fc to bc704a0 Compare December 16, 2024 16:44
@thescientist13 thescientist13 added the needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) label Dec 28, 2024
@thescientist13 thescientist13 added docs Greenwood specific content like docs and guides and removed needs upstream Notes that this item exposes an issue with a dependency (usually Greenwood) labels Jan 13, 2025
@thescientist13 thescientist13 force-pushed the enhancement/upgrade-greenwood-0.31.0 branch from d96fd29 to 527b6ad Compare January 13, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides enhancement New feature or request release/v0.31.0
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant