handle bare specifiers #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing issues on Windows with the shared state issue from #24 and so it is failing because extra state from other tests are bleeding through. Run WCC
Using renderFromHTML
static page content
✔ should have the expected <html> tag the page
✔ should have the expected <title> tag the page
✔ should have the expected <head> tag the page
✔ should have the expected <body> tag the page
✔ should have the expected static content for the page
custom header element with nested navigation element
✔ should have a <header> tag within the <template> shadowroot
✔ should have expected content within the <header> tag
nested navigation element
✔ should have a <nav> tag within the <template> shadowroot
✔ should have three links within the <nav> element
Using renderFromHTML
{
assetMetadata: [
'wcc-header': { instanceName: 'Header', moduleURL: [URL] },
'wc-events-list': { instanceName: 'EventsList', moduleURL: [URL] },
'wcc-navigation': { instanceName: 'Navigation', moduleURL: [URL] }
]
}
1) should have two custom elements in the asset graph
✔ should have the correct attributes for each assetI tried removing |
thescientist13
force-pushed
the
bug/issue-43-handle-bare-specifiers-when-parsing
branch
from
24605f0 to
29e82ff
Compare
thescientist13
changed the title
thescientist13
deleted the
bug/issue-43-handle-bare-specifiers-when-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #43
Summary of Changes
TODO