Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(robot-server): serve dev on 0.0.0.0 #17271

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from
Open

chore(robot-server): serve dev on 0.0.0.0 #17271

wants to merge 1 commit into from

Conversation

anuwrag
Copy link
Contributor

@anuwrag anuwrag commented Jan 14, 2025

Support Exposing 31950 robot-server port for Docker container

Overview

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@anuwrag
Update Makefile
1c032fd 
Support Exposing 31950 robot-server port for Docker container
@anuwrag anuwrag requested a review from a team as a code owner January 14, 2025 21:05
@SyntaxColoring SyntaxColoring mentioned this pull request Jan 15, 2025
Open
SyntaxColoring
SyntaxColoring requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for the other PR: #17270 (comment).

sfoster1
sfoster1 requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not set this by default. If you need to set the server to accept outgoing connections, please do it by overriding the variable.

@sfoster1 sfoster1 changed the title Update Makefile chore(robot-server): serve dev on 0.0.0.0 Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxColoring SyntaxColoring SyntaxColoring requested changes

@sfoster1 sfoster1 sfoster1 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuwrag @sfoster1 @SyntaxColoring