Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thermocycler): overdrive tc lid before opening from closed position #480

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Nov 14, 2024

Overview

In this thermocycler commit, we changed the procedure of opening the thermocycler lid to the following:

  • engage the solenoid latch
  • if the lid is closed, overdrive the lid further closed
  • open the lid 8 degrees
  • check the 'closed' limit switch. If it's engaged, throw an error
  • proceed to opening the lid all the way

This re-implements that change, but removes the 'latch release backoff' step, so opening the lid will now look like:

  • engage the solenoid latch
  • if the lid is closed, overdrive the lid further closed
  • proceed to opening the lid all the way

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. So complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants