-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Lerna #189
base: master
Are you sure you want to change the base?
Feature: Lerna #189
Conversation
- Added Husky - Added main tasks as mirror (all:* and server-render:* patterns)
Main Changes: - Added missing `cy:verify` script - Added sleep for 60s as workaround.
@ckarande and @lirantal seems like I was able to fix the CI issues with Lerna. 🎉 I will work now on the documentation and then I will work to enable tests in CI for #193 and #197. Important This PR seems quite big but only few files were created/edited:
The rest of the files were just moved to a new location Note We will need to review Heroku official deployment (https://nodegoat.herokuapp.com/tutorial) becuase maybe this PR will break de deploy? 🤔 |
The "A9 Insecure Components" example requires [email protected]; that's the newest version affected by the XSS described in the tutorial
In I think that means the web service is only tested under node 12 in this branch, despite there being travis jobs for node 8, 10 and 12. EDIT: Also it appears that the before/after hooks that reset the DB don't work in this branch. The docker-compose.yml doesn't map the mongo port out to the host. That means the database is only accessible from other services (just EDIT 2: When launched with |
Restore A9 vulnerability
Add test of A9 vulnerability
WIP. No Merge:
Pending
Context
Changelog