-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when running Sedge with a non root user #303
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
+ Coverage 86.69% 86.80% +0.10%
===========================================
Files 78 78
Lines 4578 4614 +36
===========================================
+ Hits 3969 4005 +36
Misses 523 523
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening such a nicely done PR very quickly! It seemed you had some fun doing this.
I wonder if these changes affect somehow clients other than Teku. Did you try several combinations?
I made some comments to be solved
cli/actions/generation.go
Outdated
} | ||
for _, datadir := range datadirs { | ||
if datadir.createIf { | ||
if _, err := os.Stat(datadir.path); os.IsNotExist(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are ignoring err
here except when it is an os.IsNotExist
. Is this intentional? There could be another type of error related to something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1741c7f
Co-authored-by: Miguel Tenorio <[email protected]>
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?