Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a slightly modified version of @aklomp's generic base64 decoder. While implementing support for
ech
on #16 (not in RFC, but supported by NSD) I required yet another slightly modified base64 parse function. Instead I opted to pull in the excellent stream decoder. While not leveraging the vectorized implementations yet (#27), using the decoder boosts performance significantly, especially for DNSSEC heavy zones (i.e..se
).before:
after:
I've also added an
endian.h
that pulls in the system'sendian.h
if available (not for macOS and Windows). The byteswap routines can be used to avoid use ofhton*
andntoh*
functions so we don't depend onwinsock.h
on Microsoft Windows.