feat: add keyboard shortcuts to add rows and columns on grid cell hover #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
suggested changes
May 17, 2021
| @@ -354,6 +355,15 @@ function onOverCell({ row, col }) { | |||
| overArea.value = props.area | |||
| } | |||
|
|
|||
| function onOverGridCell({ row, col }) { | |||
| onOverCell({ row, col }) | |||
| if (overArea.value.display === 'grid') overArea.value.grid.hover = { row, col } | |||
There was a problem hiding this comment.
We should change this to be something like overArea: { area, cell: { row, coll } }. If you check the other hover or focused states, they don't modify the design state because that is included in undo/redo automatically. So all this focus info needs to be out of the mainArea state tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to add rows and columns on current area with keys c and r:
The columns and rows added will move inner children to the right/bottom if needed.