fix(proxy-cache): follow request Cache-Control: no-cache header field
#14139
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/proxy-cache
cherry-pick kong-ee
xianghai2
approved these changes
Jan 14, 2025
oowl
changed the title
cache-control header no-cache field base on rfc7234
locao
requested changes
Jan 17, 2025
There was a problem hiding this comment.
This fix would change the cached object format instead of only refreshing it. We keep the request body in the cache and the new code is returning before storing it.
My suggestion is to skip the fetch() call when Cache-Control: no-cache and setting the correct cache status in the signal_cache_req() call.
| set_header(conf, "X-Cache-Key", cache_key) | ||
| if conf.cache_control then | ||
| if cc["no-cache"] then | ||
| return signal_cache_req(ctx, conf, cache_key, "Bypass") |
There was a problem hiding this comment.
If we return here, we're not caching the request body.
There was a problem hiding this comment.
@locao ,
Just out of curiosity, why are we caching the request body? Used somewhere else?
locao
changed the title
cache-control header no-cache field base on rfc7234Cache-Control: no-cache header
locao
changed the title
Cache-Control: no-cache headerCache-Control: no-cache header field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when the header field
Cache-Controlcontained the directiveno-cache, the proxy-cache plugin was not caching at all, which is not the behavior described by RFC-7234.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #14120
KAG-6165