-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and pass one regression test for radio widget parser #1871
base: main
Are you sure you want to change the base?
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too bad JSON doesn't allow comments. I'd love it if we could include some indication of what bug/failure is being tested for by this file.
Maybe I could change the extension to .yaml
? (YAML is a superset of JSON)
Oh, but then JSON.parse()
will fail. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a comment
property, but since this tests for type checking, that would probably fail. Would it be worth adding an optional comment
property as a valid field within all Perseus JSON - not in this PR, but maybe something at an opportune time?
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (269254a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1871 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1871 |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
This PR is a "pilot" demonstrating how regression testing for the PerseusItem
parser will work. The regression test uses production data found by running the
exhaustive test tool.
Issue: LEMS-2582
Test plan:
yarn test