-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default rows_index
and cols_index
in Jacobian
#302
base: master
Are you sure you want to change the base?
Conversation
rows_index
and cols_index
to nothing
rows_index
and cols_index
in Jacobian
This isn't quite correct either? It's correct for Matrix, but other structured sparse matrices like banded matrices do still have a non-trivial sparsity pattern, but don't use structurednz. However, in that case these are just sentinals, so I guess it's fine to have this, especially since this is legacy code at this point that should get archived in the very near future. |
The previous version was incorrect too, it basically assumed the matrix was diagonal. |
For testing this it would be great to have code coverage (#303), any idea why we don't? |
No idea what happened to code coverage. That's news to me that it's not working. Though it has always been a bit wonky with test groups. |
Agreed, that's why I still approved it. It's a sentinel in the other cases, so it should be fine? Wanted to make sure that was documented in case anyone looked back at this PR as to why it's not the right value. |
Alternately we could put |
Apparently we're hitting the rate limit of codecov but that's weird, this is JuliaDiff not SciML. Anyone else pushing updates all the time? |
Codecov's rate limit on forks is effectively zero. What's weird is that this isn't from a fork though... |
Fixed in #305 |
Looks like this breaks GPU |
We could use |
What do you want to do here @ChrisRackauckas? |
Gentle bump |
Partial fix for SciML/NonlinearSolve.jl#473