Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Cache bug. add x86 jobs #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fchorney
Copy link
Contributor

There was a CI Cache bug affecting the previous ci files (found in a different project).

there was also an exclude for macOS x86 jobs, but there were no x86 jobs actually running. Added x86 back in assuming that's what we want here.

@fchorney
Copy link
Contributor Author

Do we want nightly running on pull requests here?

@fchorney
Copy link
Contributor Author

Do we also want an explicit 1.5 job on here for when 1 ends up going to 1.6?

@mattBrzezinski
Copy link
Member

Do we also want an explicit 1.5 job on here for when 1 ends up going to 1.6?

It does exist in our internal packages, probably worth having it explicit as our stable version.

@oxinabox
Copy link
Member

Do we want nightly running on pull requests here?

Out of scope for this PR.
Can make another later if we want to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants