Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: writing TypeScript config file #2114

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

  • Fixes issue where null was inserted to typestat.json includes list
  • Fixes issue where option was inferableTypes when it should be noInferableTypes
  • Added basic testing for config generation

For future:

  • Config generation is still little bit broken. If I want to select just "Remove type annotations that don't change the meaning of code" option, the generated config file does not have it but instead has just "incompleteTypes": true. -> Needs new issue created.

🐙

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 88.11189% with 17 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (881cd89) to head (27560ec).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...nitializeTypeScript/writeSingleTypeScriptConfig.ts 59.09% 9 Missing ⚠️
...initializeTypeScript/writeMultiTypeScriptConfig.ts 81.39% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   75.50%   76.61%   +1.11%     
==========================================
  Files         177      179       +2     
  Lines        7585     7656      +71     
  Branches     1077     1086       +9     
==========================================
+ Hits         5727     5866     +139     
+ Misses       1853     1785      -68     
  Partials        5        5              
Flag Coverage Δ
mutation 64.65% <0.00%> (-0.61%) ⬇️
unit 18.79% <88.11%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate all the added test coverage, this is great!

Requesting changes on some // @ts-expect-error removals and a bit of discussion on what might be even more existing issues with the code? (🙃)

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Jan 13, 2025
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Jan 17, 2025
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This is looking great, thanks a million as usual @rubiesonthesky!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 90ef5e5 into JoshuaKGoldberg:main Jan 17, 2025
14 checks passed
Copy link

🎉 This is included in version v0.8.10 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Writing Multi stage config results having null in include files array
2 participants