-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: writing TypeScript config file #2114
fix: writing TypeScript config file #2114
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
==========================================
+ Coverage 75.50% 76.61% +1.11%
==========================================
Files 177 179 +2
Lines 7585 7656 +71
Branches 1077 1086 +9
==========================================
+ Hits 5727 5866 +139
+ Misses 1853 1785 -68
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate all the added test coverage, this is great!
Requesting changes on some // @ts-expect-error
removals and a bit of discussion on what might be even more existing issues with the code? (🙃)
src/initialization/initializeTypeScript/writeMultiTypeScriptConfig.ts
Outdated
Show resolved
Hide resolved
src/initialization/initializeTypeScript/writeMultiTypeScriptConfig.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 This is looking great, thanks a million as usual @rubiesonthesky!
🎉 This is included in version v0.8.10 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
null
in include files array #2113status: accepting prs
Overview
null
was inserted to typestat.jsonincludes
listinferableTypes
when it should benoInferableTypes
For future:
"incompleteTypes": true
. -> Needs new issue created.🐙