Make OrderRootsCacheBridge atomic #2875
Open
+14
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, there is a window where an unfortunately-timed rootsChanged event would cause a crash, as the atomic references would be nulled out between the check for their existence and their use. Fix this by returning a cache entry from the method that ensures its presence. To do this reasonably, unify the cache for Urls and VirtualFiles. Change-Id: I2264c0a726207a81d716599c2f10088c7ac32770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there is a window where an unfortunately-timed rootsChanged event would cause a crash, as the atomic references would be nulled out between the check for their existence and their use. Fix this by returning a cache entry from the method that ensures its presence. To do this reasonably, unify the cache for Urls and VirtualFiles.
Change-Id: I2264c0a726207a81d716599c2f10088c7ac32770