[kotlin][debugger] Remove bytecode inspection for coroutine method switch check #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking if a suspend method has a state machine, the debugger inspected bytecode trying to find an instruction like `getfield com/example/MainKt$foo$1.label:I`. This approach didn't work in Android Studio, which resulted in a stepping difference between IDEs. This commit introduces a simpler way of detecting if a state machine is generated for a suspend function.
nikita-nazarov
force-pushed
the
nazarov/coroutine-switch-refactoring
branch
from
75b2987
to
7a2f6e1
Compare
|
Probably this approach will not work for the cases with tail call optimization, when no state machine is generated for a suspend lambda. I'll check the cases like this. @nikita-nazarov maybe you could share an example of code, where the behavior was different? |
|
Tests that fail on Android without this inspection: |
|
Hi @mvicsokolova! Can you please take a look at this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if a suspend method has a state machine, the debugger inspected bytecode trying to find an instruction like
getfield com/example/MainKt$foo$1.label:I. This approach didn't work in Android Studio, which resulted in a stepping difference between IDEs. This commit introduces a simpler way of detecting if a state machine is generated for a suspend function.@zuevmaxim