Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5495: Add a note to a relation #5995

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Car85
Copy link

@Car85 Car85 commented Jun 15, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

#5495

What does this fix?

What is the new behavior?

Users can add a note to each relation.

What is the current behavior?

Users can't add a note to each relation.

What libraries were added/updated?

DOMPurify

Does this change affect performance?

Now users can avoid confusion in the relations by adding notes.

Does this change affect security?

DOMPurify avoid malicious code in the TextArea

What alternative approaches were there?

What feature flags were used to cover this change?

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Relations

demo-2024-06-14_14 46 57

Copy link

netlify bot commented Jun 15, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6833a90

Copy link

netlify bot commented Jun 15, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6833a90

@github-actions github-actions bot added the feat label Jun 15, 2024
@robinclaes
Copy link

Hi @Car85, if you want to be eligible for the bounty of $50 you'll need to apply to the issue here:
https://gitpay.me/#/task/757

@Car85
Copy link
Author

Car85 commented Jun 17, 2024

Hi @Car85, if you want to be eligible for the bounty of $50 you'll need to apply to the issue here: https://gitpay.me/#/task/757

Hi @robinclaes , it seems that some steps are not included. Once they are completed, I will send the solution.

image

@Car85
Copy link
Author

Car85 commented Jun 17, 2024

I'm on the tests right now, will get to the PR soon.

@Car85 Car85 changed the title feat: 5495: Add a note to a relations feat: 5495: Add a note to a relation Jun 21, 2024
@robot-ci-heartex
Copy link
Collaborator

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@Car85 Car85 marked this pull request as draft August 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants