-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zimfw 1.17.0 (new formula) #204464
base: master
Are you sure you want to change the base?
zimfw 1.17.0 (new formula) #204464
Conversation
def caveats | ||
<<~EOS | ||
Get started with a sample configuration file: | ||
|
||
cp -n #{opt_share}/examples/zimrc ${ZDOTDIR:-${HOME}}/.zimrc | ||
|
||
Add the following to your .zshrc: | ||
|
||
ZIM_HOME=${ZDOTDIR:-${HOME}}/.zim | ||
# Install missing modules, and update ${ZIM_HOME}/init.zsh if missing or outdated. | ||
if [[ ! ${ZIM_HOME}/init.zsh -nt ${ZIM_CONFIG_FILE:-${ZDOTDIR:-${HOME}}/.zimrc} ]]; then | ||
source #{opt_share}/zimfw.zsh init -q | ||
fi | ||
# Initialize modules. | ||
source ${ZIM_HOME}/init.zsh | ||
EOS | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the opt_share locations seem specific to Homebrew right? Maybe we can shorten this to:
Find an example in
#{opt_share}/examples/zimr
and source from#{opt_share}/zimfw.zsh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SMillerDev. I wanted to keep the instructions for a quick but complete setup. The snippet for the .zshrc file is unfortunately that long. I also like how the current instructions say the configuration must go specifically to ${ZDOTDIR:-${HOME}}/.zimrc
, and the installation is useless without a configuration file.
Or maybe I should add the installation details to our own documentation in the zimfw repository and then the caveats here could look like just:
To finish the set up, see:
https://github.com/zimfw/zimfw#...
Source from #{opt_share}/zimfw.zsh in your .zshrc.
And we can even remove the example configuration if the idea is to keep the instructions here to a minimum.
Let me know the preferred direction. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caveats are really only for instructions that are specific to the Homebrew install. The location of the files is specific, if you have documentation for the other parts I don't think they should be in the caveat.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Disclaimer: I'm the maintainer of zimfw.
As requested in zimfw/zimfw#530