Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iota 0.8.1-rc (new formula) #204325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thibault-martinez
Copy link

@thibault-martinez thibault-martinez commented Jan 15, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is the CLI for the the IOTA Testnet.

brew audit --new <formula> is failing with Error: These formulae are not in any locally installed taps!
Am I supposed to install my forked repository as tap? But then the formula is not on the master branch so it still wouldn't find it?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue missing license Formula has a missing license which should be added labels Jan 15, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@SMillerDev
Copy link
Member

Am I supposed to install my forked repository as tap? But then the formula is not on the master branch so it still wouldn't find it?

https://docs.brew.sh/Adding-Software-to-Homebrew#formulae

class Iota < Formula
desc "Bringing the real world to Web3 with a scalable, decentralized and programmable DLT infrastructure"
homepage "https://www.iota.org"
url "https://github.com/iotaledger/iota/archive/refs/tags/v0.8.1-rc.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to ship release candidates, from the requirements page:

be stable (e.g. not declared “unstable” or “beta” by upstream)

https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff:~:text=be%20stable%20(e.g.%20not%20declared%20%E2%80%9Cunstable%E2%80%9D%20or%20%E2%80%9Cbeta%E2%80%9D%20by%20upstream)

Copy link
Author

@thibault-martinez thibault-martinez Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sean, in this case RC is about our deployment which goes from Devnet (alpha/beta, unstable) to Testnet (rc, stable) to Mainnet (stable). RC is a finished and stable release but just not yet deployed on our Mainnet.
This is very similar to the sui formula but they have opted for a testnet- suffix https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/sui.rb#L4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one shouldn't ship testing level software either, we might want to disable that one.

Comment on lines 13 to 14
depends_on "cmake" => :build
depends_on "libpq" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it vendoring that it needs these things?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed missing license Formula has a missing license which should be added labels Jan 15, 2025
@thibault-martinez thibault-martinez force-pushed the new-formula-iota-0.8.1-rc branch from 2c3c755 to d868677 Compare January 15, 2025 12:37
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants