-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logalize 0.4.1 (new formula) #197757
base: master
Are you sure you want to change the base?
logalize 0.4.1 (new formula) #197757
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
url "https://github.com/deponian/logalize.git", | ||
tag: "v0.4.1", | ||
revision: "2d74f36f36037d1a09371f044a85b2b8f192905f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url "https://github.com/deponian/logalize.git", | |
tag: "v0.4.1", | |
revision: "2d74f36f36037d1a09371f044a85b2b8f192905f" | |
url "https://github.com/deponian/logalize/archive/refs/tags/v0.4.1.tar.gz" | |
sha256 "xxx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application needs commit hash during the building stage, so I need to use tag-revision approach here. The installation process assumes that we are inside the Git repository and have access to the commit history
system "make", "VERSION=#{version}", "build" | ||
bin.install "dist/#{version}/logalize" | ||
|
||
system "make", "VERSION=#{version}", "manpage" | ||
man1.install "manpages/logalize.1.gz" | ||
|
||
system "make", "completions" | ||
bash_completion.install "completions/logalize.bash" => "logalize" | ||
zsh_completion.install "completions/logalize.zsh" => "_logalize" | ||
fish_completion.install "completions/logalize.fish" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system "make", "VERSION=#{version}", "build" | |
bin.install "dist/#{version}/logalize" | |
system "make", "VERSION=#{version}", "manpage" | |
man1.install "manpages/logalize.1.gz" | |
system "make", "completions" | |
bash_completion.install "completions/logalize.bash" => "logalize" | |
zsh_completion.install "completions/logalize.zsh" => "_logalize" | |
fish_completion.install "completions/logalize.fish" | |
ldflags = "xxx" | |
system "go", "build", *std_go_args(ldflags:), "./cmd" | |
generate_completions_from_executable(bin/"logalize", "completion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I's much simpler for me as developer of the application to build everything using make
. This way I'll be able to change building process in the future without changing the formula
@chenrui333 Hi! So there is no way to add Logalize to Homebrew Core without 75 starts on Github, right? |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?