Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logalize 0.4.1 (new formula) #197757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deponian
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 14, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Comment on lines +4 to +6
url "https://github.com/deponian/logalize.git",
tag: "v0.4.1",
revision: "2d74f36f36037d1a09371f044a85b2b8f192905f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://github.com/deponian/logalize.git",
tag: "v0.4.1",
revision: "2d74f36f36037d1a09371f044a85b2b8f192905f"
url "https://github.com/deponian/logalize/archive/refs/tags/v0.4.1.tar.gz"
sha256 "xxx"

Copy link
Author

@deponian deponian Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application needs commit hash during the building stage, so I need to use tag-revision approach here. The installation process assumes that we are inside the Git repository and have access to the commit history

Comment on lines +13 to +22
system "make", "VERSION=#{version}", "build"
bin.install "dist/#{version}/logalize"

system "make", "VERSION=#{version}", "manpage"
man1.install "manpages/logalize.1.gz"

system "make", "completions"
bash_completion.install "completions/logalize.bash" => "logalize"
zsh_completion.install "completions/logalize.zsh" => "_logalize"
fish_completion.install "completions/logalize.fish"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system "make", "VERSION=#{version}", "build"
bin.install "dist/#{version}/logalize"
system "make", "VERSION=#{version}", "manpage"
man1.install "manpages/logalize.1.gz"
system "make", "completions"
bash_completion.install "completions/logalize.bash" => "logalize"
zsh_completion.install "completions/logalize.zsh" => "_logalize"
fish_completion.install "completions/logalize.fish"
ldflags = "xxx"
system "go", "build", *std_go_args(ldflags:), "./cmd"
generate_completions_from_executable(bin/"logalize", "completion")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I's much simpler for me as developer of the application to build everything using make. This way I'll be able to change building process in the future without changing the formula

@chenrui333 chenrui333 added the notability Project is not notable enough for inclusion label Nov 14, 2024
@deponian
Copy link
Author

@chenrui333 Hi! So there is no way to add Logalize to Homebrew Core without 75 starts on Github, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants