Bump some utils/ files to Sorbet typed: strict
#19094
Open
+206
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Jan 15, 2025
| @@ -97,8 +97,8 @@ def pypi_info(new_version: nil) | |||
| sig { returns(String) } | |||
| def to_s | |||
| if valid_pypi_package? | |||
| out = name | |||
| out += "[#{extras.join(",")}]" if extras.present? | |||
| out = T.must(name) | |||
There was a problem hiding this comment.
If we're doing a T.must here feels like it might be nice to enforce in def name and def initialize that it's a String type instead?
| tcsh: "~/.tcshrc", | ||
| zsh: "~/.zshrc", | ||
| }.freeze, | ||
| T::Hash[T.nilable(Symbol), String], |
There was a problem hiding this comment.
Suggested change
| T::Hash[T.nilable(Symbol), String], | |
| T::Hash[Symbol, String], |
feels more appropriate?
There was a problem hiding this comment.
Tried that, but in def profile’s SHELL_PROFILE_MAP.fetch(preferred, "~/.profile") , preferred can be nil and there’s no default fallback.
There was a problem hiding this comment.
Does that produce a type-error? Feels like it might be nicer in that case to have an early return rather than attempting a fetch with nil. Thoughts?
There was a problem hiding this comment.
Yes. And good idea, yeah, I'll do that.
Co-authored-by: Mike McQuaid <[email protected]>
issyl0
force-pushed
the
utils-sorbet-strict
branch
from
7a069dd to
4941137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?typed: strictin all (non-package) files in Homebrew organisation #17297.