-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pending to dashboard #2250
Open
heyitsmebev
wants to merge
11
commits into
main
Choose a base branch
from
2199-add-pending-message-data-to-daily-and-user_daily-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add pending to dashboard #2250
heyitsmebev
wants to merge
11
commits into
main
from
2199-add-pending-message-data-to-daily-and-user_daily-stats
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjanousekGSA
approved these changes
Jan 15, 2025
@heyitsmebev - Small change - make the Pending color #C7CACE (same color as the remaining color above and shows up well in the colorblindness test) |
const COLORS = { | ||
delivered: '#0076d6', | ||
failed: '#fa9441', | ||
pending: '#808080', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#C7CACE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this ticket is to update the dashboard UI to display the number of pending statuses, similar to the job page, where delivery statuses for pending, delivered, and failed messages are shown.
Ticket: #2199
These numbers should align with those provided by Jobs and Notifications table and remain consistent across both job statuses and notification statuses.
Users should see "pending" when a message is initiated, and as messages are delivered, the chart on the dashboard should update accordingly.
When testing, you may need to pull in
2199-add-pending-message-data-to-daily-and-user_daily-stats
in your API repoUI dashboard