1871 search activity page #1893
Conversation
…o 1871-search-activity-page
|
Pausing on this as it doesn't search the entire dataset, and it should |
| liveRegion.textContent = `${visibleRowCount} result${visibleRowCount !== 1 ? 's' : ''} found`; | ||
|
|
||
| // Check if there are no visible rows | ||
| if (visibleRowCount === 0) { |
There was a problem hiding this comment.
If this is the same code that is in searchActivity regarding business logic, it might make sense to extract this logic to a generic helper file so that we can reuse that same logic in the javascript tests. This way if future updates are needed, it only needs to be done in one place instead of multiple.
I am still learning context and might be missing something here, so ill go ahead and approve, but if you think its a good idea as well then you can make that change!
There was a problem hiding this comment.
@alexjanousekGSA - we're actually waiting on some back end work to provide an endpoint to search against, so this might change. When that happens I'll reach back out to see if it's worth editing for testing-sake.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
Adding type-ahead search functionality to the Activity landing page in the Dashboard area
TODO