Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guild): support guild incidents #1230

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat(guild): support guild incidents #1230

wants to merge 11 commits into from
+174 −6

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Aug 16, 2024 •
edited
Loading

Summary

Adds IncidentsData, as well as two new parameters invites_disabled_until and dms_disabled_until to Guild.edit.

The already existing invites_disabled parameter (and corresponding INVITES_DISABLED feature) still works, and appears to override any duration set by invites_disabled_until on Discord's end.

discord/discord-api-docs#6396

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Aug 16, 2024
Skelmis
Skelmis approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but this looks good and appears to line up with ddocs expectations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftinv @Skelmis