feat(emoji): implement app emojis #1224
Open
+316
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftinv
added
t: enhancement
|
I marked this ready for review even though i still don't know if we should provide the ability to cache app emojis at startup, as you can see i did put a boolean argument but didn't implement any logic for it so far. |
Victorsitou
reviewed
Oct 22, 2024
| Parameters | ||
| ---------- | ||
| name: :class:`str` | ||
| The name of the new string. |
There was a problem hiding this comment.
Suggested change
| The name of the new string. | |
| The emoji name. Must be at least 2 characters. |
| Retrieves all the :class:`.Emoji` of the application. | ||
|
|
||
| .. versionadded:: 2.10 | ||
|
|
| @@ -51,6 +51,10 @@ class Emoji(_EmojiTag, AssetMixin): | |||
|
|
|||
| Returns the emoji rendered for Discord. | |||
|
|
|||
| .. versionchanched:: 2.10 | |||
|
|
|||
| This class can now represents app emojis too. Denoted by having :attr:`.Emoji.guild_id` as ``None``. | |||
There was a problem hiding this comment.
Maybe a is_app_emoji property would be nice here
|
|
||
| @property | ||
| def application_id(self) -> Optional[int]: | ||
| """:class:`int`: The ID of the application which owns this emoji. |
There was a problem hiding this comment.
Suggested change
| """:class:`int`: The ID of the application which owns this emoji. | |
| """Optional[:class:`int`]: The ID of the application which owns this emoji. |
| .. versionadded:: 2.10 | ||
| """ | ||
| if self.guild is None: | ||
| return |
There was a problem hiding this comment.
Suggested change
| return | |
| return None |
| @@ -51,6 +51,10 @@ class Emoji(_EmojiTag, AssetMixin): | |||
|
|
|||
| Returns the emoji rendered for Discord. | |||
|
|
|||
| .. versionchanched:: 2.10 | |||
There was a problem hiding this comment.
Suggested change
| .. versionchanched:: 2.10 | |
| .. versionchanged:: 2.10 |
| HTTPException | ||
| An error occurred creating an app emoji. | ||
| TypeError | ||
| The ``image`` asset is a lottie sticker (see :func:`Sticker.read`). |
There was a problem hiding this comment.
Suggested change
| The ``image`` asset is a lottie sticker (see :func:`Sticker.read`). | |
| The ``image`` asset is a lottie sticker (see :func:`Sticker.read <disnake.Sticker.read>`). |
Comment on lines
+169
to
+177
| """Optional[:class:`Guild`]: The guild this emoji belongs to. | ||
|
|
||
| ``None`` if this is an app emoji. | ||
|
|
||
| .. versionchanged:: 2.10 | ||
|
|
||
| This can now return ``None`` if the emoji is an | ||
| application owned emoji. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """Optional[:class:`Guild`]: The guild this emoji belongs to. | |
| ``None`` if this is an app emoji. | |
| .. versionchanged:: 2.10 | |
| This can now return ``None`` if the emoji is an | |
| application owned emoji. | |
| """ | |
| """Optional[:class:`Guild`]: The guild this emoji belongs to. ``None`` if this is an app emoji. | |
| .. versionchanged:: 2.10 | |
| This can now return ``None`` if the emoji is an | |
| application owned emoji. | |
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
pdm lintpdm pyright