Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ca.json #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ca.json #558

wants to merge 1 commit into from

Conversation

axelsrk
Copy link

@axelsrk axelsrk commented Oct 3, 2022

Are you happy for it to be included and distributed under the MIT license? ✔️/❌

@AllanJard
Copy link
Contributor

Hi - thanks for this. However, per the contributing document could you send changes for the language file here please.

@samuelstroschein
Copy link

@AllanJard What is/are the benefit(s) of using datatables for translation contributions?

@AllanJard
Copy link
Contributor

I think the UI is much more approachable: https://datatables.net/plug-ins/i18n/ . It also allows much easier management for us.

I know there will be some who prefer to contribute with Git, and some day I hope to be able to make the time to sync the data both ways, but at the moment I'm prioritising other things.

@samuelstroschein
Copy link

@AllanJard Thanks for the reply. I can't seem to "start" the UI. When I click on German I get to the following page https://datatables.net/plug-ins/i18n/German.html.

I know there will be some who prefer to contribute with Git, and some day I hope to be able to make the time to sync the data both ways, but at the moment I'm prioritising other things.

I could open a PR that adds https://github.com/inlang/inlang and thereby makes contributions easier + it should reduce the effort for you as a maintainer (no sync, whatsoever required). If not, let me know right away because I made design mistakes otherwise.

Would a PR be of help to you?

PS I am the maintainer of inlang.

@AllanJard
Copy link
Contributor

I can't seem to "start" the UI

You need to click the "Contribute" button in the table on the right hand side:

image

You need to login / create an account to be able to submit translations.

I could open a PR that adds https://github.com/inlang/inlang and thereby makes contributions easier

It looks awesome! I think I'm fairly happy with our contribution solution at the moment though as it provides tailored information about where the translated text will be used and screenshots of it, in order to give context to the translator. It is also quite tightly integrated into our site and I think works reasonably well for the large number of languages we have translations for.

@samuelstroschein
Copy link

I think I'm fairly happy with our contribution solution at the moment though

Noted!

Regarding your solution:

Wow, I totally overlooked the "login to contribute" text. May I suggest changing the text to a button and thereby nudge users to login?

CleanShot 2023-01-31 at 18 51 48@2x

The screenshots are awesome. Are they autogenerated?

CleanShot 2023-01-31 at 18 54 57@2x

@AllanJard
Copy link
Contributor

Good idea - I'll get that changed.

And unfortunately no - they are screenshots with a little manual image editing. It takes a while... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants