Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Service Extension (Envoy External Processing) #3377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Nov 5, 2024

Motivation

Tests the new ASM Integration Service Extension.

Changes

Import tests from APM and ASM that applies to the Service Extension.
The import is using class generation to correctly import tests that should work and skip the ones that will not work.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@e-n-0 e-n-0 force-pushed the flavien/external_proc_tests branch 2 times, most recently from 6b788b1 to a64f21b Compare November 5, 2024 18:02
@e-n-0 e-n-0 force-pushed the flavien/external_proc_tests branch from a64f21b to 1ff2cb4 Compare November 5, 2024 18:54
@e-n-0 e-n-0 marked this pull request as ready for review November 5, 2024 18:55
@e-n-0 e-n-0 requested a review from a team as a code owner November 5, 2024 18:55
@@ -0,0 +1,55 @@
from utils import weblog, interfaces, scenarios, features

from tests.test_config_consistency import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that, it'll duplicate base test class. Let meet with zoom to see the best way to achieve this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from tests import test_semantic_conventions as base_semantic_conventions


@scenarios.external_processing
class Test_Meta(base_semantic_conventions.Test_Meta):
    @irrelevant(True, reason="The meta component tag would always be http.request and not external-processing")
    def test_meta_component_tag(self):
         super().test_meta_component_tag()
    
@scenarios.external_processing 
class Test_EnvVar(base_semantic_conventions.Test_Meta):
    pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants