[sotw][issue-540] Return full state when applicable for watches in linear cache #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ches subscribing to multiple resources Properly return the request in sotw responses to allow proper handling in callbacks Signed-off-by: Valerian Roche <[email protected]>
…near cache Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
changed the title
atollena
approved these changes
Jan 15, 2024
Co-authored-by: Antoine Tollenaere <[email protected]> Signed-off-by: Valerian Roche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog fork PR matching envoyproxy#856
This PR is currently based on #4 , and include its diff too, but in a separate commit
Fixes envoyproxy#540
This PR is fixing issue envoyproxy#540: the xds protocol defines that for the resource types Listener and Cluster, when using sotw watches, the cache must return as part of the response all existing resources matching the requests if not wildcard.
Currently the control-plane will only return the modified resources on cache updates, and the protocol states that the client should interpret such a response as a deletion
In simple cache this distinction is not applicable as we currently always return all resources. While we may want to improve this behavior in the future (e.g. to avoid sending all clusters if only one was updated in delta, or to send a single route configuration in sotw on update), this is out of scope of this PR as this requires keeping more state