Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate (and expired) flaky marker from the aws lambda test #11428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Nov 15, 2024

There's currently two flaky decorators on the test aws lambda file.

@flaky(1735812000) -> Jan 2, 2025
@flaky(1709306303) -> March 1, 2024

The purpose of this is to remove the expired one.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/aws_lambda/test_aws_lambda.py                             @DataDog/apm-core-python @DataDog/apm-idm-python

@wantsui wantsui changed the title chore: remove duplicate (and expired) flaky marker from the aws lambda test. chore: remove duplicate (and expired) flaky marker from the aws lambda test Nov 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-15 20:48:23

Comparing candidate commit 9609b0f in PR branch wantsui/remove-duplicate-flaky-from-aws with baseline commit ecd0ab1 in branch main.

Found 6 performance improvements and 0 performance regressions! Performance is the same for 382 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

  • 🟩 execution_time [-739.117ns; -676.521ns] or [-12.549%; -11.487%]

scenario:iast_aspects-ospathnormcase_aspect

  • 🟩 execution_time [-429.826ns; -397.498ns] or [-14.973%; -13.847%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟩 execution_time [-605.194ns; -547.890ns] or [-13.509%; -12.230%]

scenario:iast_aspects-split_aspect

  • 🟩 execution_time [-310.373ns; -283.041ns] or [-15.530%; -14.162%]

scenario:iast_aspects-splitlines_aspect

  • 🟩 execution_time [-185.941ns; -160.676ns] or [-9.841%; -8.504%]

scenario:iast_aspects-swapcase_aspect

  • 🟩 execution_time [-337.347ns; -289.368ns] or [-10.375%; -8.899%]

@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant