-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [SVLS-5953] pointers for deserialized DynamoDB requests #11420
base: main
Are you sure you want to change the base?
fix: [SVLS-5953] pointers for deserialized DynamoDB requests #11420
Conversation
c9f1438
to
ce4c3ab
Compare
built on top of #11353 |
|
BenchmarksBenchmark execution time: 2024-11-15 20:35:44 Comparing candidate commit c91582f in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 384 metrics, 2 unstable metrics. scenario:iast_aspects-ospathsplitext_aspect
scenario:iast_aspects-split_aspect
scenario:iast_aspects-splitlines_aspect
scenario:iast_aspects-upper_aspect
|
confirmed that this change works as expected in a test lambda environment. |
c467f9d
to
9d668a7
Compare
ce4c3ab
to
d32ff1d
Compare
d32ff1d
to
07cc209
Compare
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 24m 10.93s Total duration (11m 44.01s time saved) |
Fixes #11320 .
The resource-based APIs for DynamoDB in boto3 accept deserialized python values and turn them into proper type-tagged DynamoDB API objects in the background. Unfortunately we don't seem to have access to those lower-level type-tagged objects, so if we see the deserialized forms we need to transform them ourselves in order to correctly extract the key values for hashing into span pointers.
Checklist
Reviewer Checklist