⚡️ [RUM-7650] GA delaying the viewport dimension collection #3248
+5
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/ga-delay-viewport-collection
branch
from
4e8b721 to
0a4ca70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3248 +/- ##
==========================================
- Coverage 93.34% 93.34% -0.01%
==========================================
Files 287 287
Lines 7784 7782 -2
Branches 1759 1758 -1
==========================================
- Hits 7266 7264 -2
Misses 518 518 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GA the optimisation following #3209
Delaying the viewport dimension lend a good results in terms of performance and reliability impact. (less than 0.1% of initial load views don't have the dimension)
Changes
delay_viewport_collectionfeature flagTesting
I have gone over the contributing documentation.