fix: add default value for access token in HttpClient init #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
0.8.12 introduced a new
access_token
parameter to theclickhouse_connect.driver.HttpClient
class that is marked asOptional[str]
but has no default value. It is properly defaulted increate_client
, but if you directly create an instance ofHttpClient
in 0.8.12, it fails due to the missing new argumentThis PR adds a
None
default value to theHttpClient
__init__
to mirrorcreate_client
and fix the issueChecklist
Delete items not relevant to your PR:
access_token
parameter of theHttpClient.__init__
method