Update draftable edition sections #6274
Open
+780
−1,715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ayora29
commented
Oct 11, 2024
•
Ayora29
commented
- FileSection.java : Use a LinkedHashMap to parse edition section, preserving section order and improve performance.
- CardEdition.java : Increment art index when multiple cards with the same name are in the same sheet. Add new section names, remove irrelevant ones.
- Edition txt files of draftable sets : update "sections" and "Booster=" parts to better reflect reallity (cf scryfall and mtg.fandom.com) and reduce amount of unecessary additionnal sections/sheets.
- printsheets.txt : remove unecessary or dead sections
- No card addition, no card remove, no cards in different order compared to before (exept some basic lands)
- I have tested drafts for all editions that I have modified
Add "scheme" section Add fallback sheet in BoosterGenerator Rewrite FileSection and Use LinkedHashMap for sections map
Merge master into edition_sections branch
tool4ever
reviewed
Oct 11, 2024
tehdiplomat
reviewed
Oct 13, 2024
| Base=Land:fromSheet("BLB full art") | ||
| Replace=.20F Land:fromSheet("BLB full art")+ | ||
| Base=BasicLand:fromSheet("BLB cards") | ||
| Replace=.20F BasicLand:fromSheet("BLB cards")+ | ||
|
|
||
| [Wildcard] | ||
| Base=Common:fromSheet("BLB cards") | ||
| # I don't know about these numbers, so i'm just copying them from MH3 |
There was a problem hiding this comment.
Wanna remove this line if you are fixing it?
There was a problem hiding this comment.
I didn't find the exact numbers for rarity distribution of the wildcard slot for BLB. So I have kept this comment.
There was a problem hiding this comment.
Or maybe should I simply use :
[Wildcard]
Any:fromSheet("BLB cards")
paulsnoops
reviewed
Oct 14, 2024
paulsnoops
reviewed
Oct 14, 2024
|
I think we'll merge this after the Foundations release. Thanks for cleaning all this up. |
|
Ok great :) |
paulsnoops
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.