-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fix for issue #1967 #2404
base: main
Are you sure you want to change the base?
Conversation
@blperf please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
/azp run |
@@ -76,6 +76,10 @@ export default class FSExtentStore implements IExtentStore { | |||
|
|||
private persistencyPath: Map<string, string>; | |||
|
|||
private circularStreamsBuffer: FileLazyReadStream[]; | |||
|
|||
private maxStreams = 100000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share how you select this number?
Mainly the change looks good to me. We may need to do some test first @blperf blperf , it'd be really helpful if you could share tests you have done. |
Tried with downloading a 8G file multiple times, but seems still meet the hang issue. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
main
branch.legacy-dev
branch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Release
section inChangeLog.md
.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.