Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dom and component focus #978

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Merge dom and component focus #978

wants to merge 7 commits into from

Conversation

horrifyingHorse
Copy link

Following the approach discussed in #970 to resolve #935

@horrifyingHorse horrifyingHorse force-pushed the update branch 2 times, most recently from b148798 to f381317 Compare December 29, 2024 22:59
@horrifyingHorse
Copy link
Author

Greetings,

I suppose it's fixed now, although i would like to add that i had to accommodate the SetCursor of Focus::Render in Node::Render, anywhere else, it kept messing up the cursor on input.

Is there any better way to do it?

@ArthurSonzogni
Copy link
Owner

Excellent!
At first sight, it looks exactly as I hoped!

I am quite busy at the moment. I will take a deeper look as soon as possible. Thank you very much for making this patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last scroll position of the vertical/horizontal container being reset when it's out of focus.
2 participants
@horrifyingHorse @ArthurSonzogni